Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda packaging in dev #226

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

folmos-at-orange
Copy link
Member

@folmos-at-orange folmos-at-orange commented Apr 8, 2024

Same as #214 but for dev

.gitignore Outdated
@@ -20,7 +20,11 @@ CMakeFiles/
# Test exceptions
test/UnitTests/*/results/
test/LearningTest/*/*/*/results/
test/*/results/
test/LearningTest/*/*/*/results.ref/time.log
results/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 23 and 25 are redundant with 21 and 22. We can choose to set only line 25 over 21 22 and 23 (to discuss)
line 24 is wrong, we have to keep time.log in results.ref

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just not to have a range too large how about test/**/results/ ?

Copy link
Contributor

@bruno-at-orange bruno-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just modify the .gitignore file

@folmos-at-orange folmos-at-orange force-pushed the update-conda-packaging-in-dev branch from 37e5ba6 to 0c691c2 Compare April 9, 2024 13:54
We recover the CI workflow from khiops-python. Now the conda packaging
of the Khiops binaries (`khiops-core` package) in the khiops domain.
@folmos-at-orange folmos-at-orange force-pushed the update-conda-packaging-in-dev branch from 0c691c2 to 7e3a233 Compare April 9, 2024 15:02
@folmos-at-orange folmos-at-orange merged commit bc3c6b6 into dev Apr 9, 2024
14 checks passed
@folmos-at-orange folmos-at-orange deleted the update-conda-packaging-in-dev branch April 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants